Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support CMK linked storage accounts #521

Merged
merged 24 commits into from
Feb 24, 2025
Merged

Added support CMK linked storage accounts #521

merged 24 commits into from
Feb 24, 2025

Conversation

tagolovina
Copy link
Contributor

@tagolovina tagolovina commented Feb 5, 2025 •
edited
Loading

This PR adds/removes

  1. Added new parameter to use customer-managed storage accounts in scheduled query alert rules
  2. Removed Computers to Include parameter because of policy parameters limit.
  3. Created documentation about customer-managed storage accounts in scheduled query alert rules

Breaking Changes

  1. Yes
    image

image

image

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@judyer28 judyer28 added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Feb 14, 2025
@tagolovina tagolovina linked an issue Feb 21, 2025 that may be closed by this pull request
[Feature Request]: Add support for customer-managed keys #418
Closed
1 task
@Brunoga-MS Brunoga-MS changed the title Added new parameter to support CMK, removed Computers to Include parameter Added new parameter to support CMK Feb 21, 2025
@tagolovina tagolovina closed this Feb 21, 2025
@tagolovina tagolovina reopened this Feb 21, 2025
@tagolovina tagolovina marked this pull request as ready for review February 21, 2025 18:43
@tagolovina tagolovina requested review from a team as code owners February 21, 2025 18:43
@Brunoga-MS Brunoga-MS changed the title Added new parameter to support CMK Added support CMK linked storage accounts Feb 22, 2025
Brunoga-MS
Brunoga-MS approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brunoga-MS Brunoga-MS merged commit 2da3e1b into Azure:main Feb 24, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brunoga-MS Brunoga-MS Brunoga-MS approved these changes

Assignees
No one assigned
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for customer-managed keys
4 participants
@tagolovina @Brunoga-MS @judyer28 @tgolovina