Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft Translator - Azure AI Translator] API Review #32596

Open
azure-sdk opened this issue Feb 13, 2025 · 1 comment · May be fixed by #32733
Open

[Microsoft Translator - Azure AI Translator] API Review #32596

azure-sdk opened this issue Feb 13, 2025 · 1 comment · May be fixed by #32733
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: Microsoft Translator - Azure AI Translator
Review Created By: Scott Greenwood
Review Date: 02/20/2025 08:00 AM PT
Release Plan: 1252
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Adding LLM support to the translator API

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Feb 13, 2025
@mikekistler mikekistler linked a pull request Feb 20, 2025 that will close this issue
@mikekistler
Copy link
Member

Notes from API Review 2/20/25

  • Recommend rename modelType to model
  • Should model be "deploymentName" ? This is the convention in Azure.
    • Look into this
  • Add a default value on the model / deploymentName.
    • And remove the "?" because the property is not "optional" in the resource
  • Remove lines 119 - 124
  • Need to update your API version
    • And switch to date-based versioning if possible
  • Adding a new property to the body (in a new api version) and making it mutually exclusive to an existing property is not breaking.

Pls address the above and then request a re-review and we can probably sign off without an additional meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

2 participants