From 58802838da4df57ee81a83ceed1fc5aa92822898 Mon Sep 17 00:00:00 2001 From: Theodore Tsirpanis Date: Wed, 6 Dec 2023 16:03:51 +0200 Subject: [PATCH 1/5] Disable default features in libxml2. We don't seem to make use of any of them in `xml_wrapper.cpp`. --- sdk/storage/azure-storage-common/vcpkg.json | 3 ++- sdk/storage/azure-storage-common/vcpkg/vcpkg.json | 3 ++- vcpkg.json | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/sdk/storage/azure-storage-common/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg.json index 624ed9925c..ee66d4f161 100644 --- a/sdk/storage/azure-storage-common/vcpkg.json +++ b/sdk/storage/azure-storage-common/vcpkg.json @@ -11,7 +11,8 @@ "azure-core-cpp", { "name": "libxml2", - "platform": "!windows" + "platform": "!windows", + "default-features": false }, { "name": "openssl", diff --git a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json index e52ffb5c4b..9bcab93be8 100644 --- a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json +++ b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json @@ -22,7 +22,8 @@ }, { "name": "libxml2", - "platform": "!windows" + "platform": "!windows", + "default-features": false }, { "name": "openssl", diff --git a/vcpkg.json b/vcpkg.json index cc5c112b98..7666e2edd9 100644 --- a/vcpkg.json +++ b/vcpkg.json @@ -8,7 +8,8 @@ }, { "name": "libxml2", - "platform": "!windows & !uwp" + "platform": "!windows & !uwp", + "default-features": false }, { "name": "openssl" From b281ec4f3977da2f3f0607dcec3076b3fbebb14a Mon Sep 17 00:00:00 2001 From: Theodore Tsirpanis Date: Wed, 6 Dec 2023 16:08:47 +0200 Subject: [PATCH 2/5] Update changelog. --- sdk/storage/azure-storage-common/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md index ad804eadb3..30c704fbb1 100644 --- a/sdk/storage/azure-storage-common/CHANGELOG.md +++ b/sdk/storage/azure-storage-common/CHANGELOG.md @@ -4,6 +4,8 @@ ### Features Added +- Removed unnecessary dependencies on non-Windows platforms. (A community contribution, courtesy of _[teo-tsirpanis](https://github.com/teo-tsirpanis)_) + ### Breaking Changes ### Bugs Fixed From addae04835f934c340f5d1e19cc16c36e406f6d5 Mon Sep 17 00:00:00 2001 From: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Date: Thu, 7 Dec 2023 13:34:34 -0800 Subject: [PATCH 3/5] Added "Acknowledgments" section to the Storage Changelog. --- sdk/storage/azure-storage-common/CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md index 30c704fbb1..5a4c775f9a 100644 --- a/sdk/storage/azure-storage-common/CHANGELOG.md +++ b/sdk/storage/azure-storage-common/CHANGELOG.md @@ -12,6 +12,12 @@ ### Other Changes +### Acknowledgments + +Thank you to our developer community members who helped to make Azure Identity better with their contributions to this release: + +- Theodore Tsirpanis _([GitHub](https://github.com/teo-tsirpanis))_ + ## 12.5.0 (2023-11-07) ### Features Added From c64453f56e9db933b2d3699d398833ebf5a36b09 Mon Sep 17 00:00:00 2001 From: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Date: Thu, 7 Dec 2023 13:42:27 -0800 Subject: [PATCH 4/5] "Identity" => "Storage" (my bad) --- sdk/storage/azure-storage-common/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md index 5a4c775f9a..592642c932 100644 --- a/sdk/storage/azure-storage-common/CHANGELOG.md +++ b/sdk/storage/azure-storage-common/CHANGELOG.md @@ -14,7 +14,7 @@ ### Acknowledgments -Thank you to our developer community members who helped to make Azure Identity better with their contributions to this release: +Thank you to our developer community members who helped to make Azure Storage better with their contributions to this release: - Theodore Tsirpanis _([GitHub](https://github.com/teo-tsirpanis))_ From bb5ae321f4b47bc193b586b0f153c991d7a68288 Mon Sep 17 00:00:00 2001 From: Theodore Tsirpanis Date: Thu, 7 Dec 2023 23:54:33 +0200 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> --- sdk/storage/azure-storage-common/vcpkg.json | 4 ++-- sdk/storage/azure-storage-common/vcpkg/vcpkg.json | 4 ++-- vcpkg.json | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sdk/storage/azure-storage-common/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg.json index ee66d4f161..fe8c4cadf6 100644 --- a/sdk/storage/azure-storage-common/vcpkg.json +++ b/sdk/storage/azure-storage-common/vcpkg.json @@ -11,8 +11,8 @@ "azure-core-cpp", { "name": "libxml2", - "platform": "!windows", - "default-features": false + "default-features": false, + "platform": "!windows" }, { "name": "openssl", diff --git a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json index 9bcab93be8..5389bf0527 100644 --- a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json +++ b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json @@ -22,8 +22,8 @@ }, { "name": "libxml2", - "platform": "!windows", - "default-features": false + "default-features": false, + "platform": "!windows" }, { "name": "openssl", diff --git a/vcpkg.json b/vcpkg.json index 7666e2edd9..3f796f2547 100644 --- a/vcpkg.json +++ b/vcpkg.json @@ -8,8 +8,8 @@ }, { "name": "libxml2", - "platform": "!windows & !uwp", - "default-features": false + "default-features": false, + "platform": "!windows & !uwp" }, { "name": "openssl"