Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose track2 module name and version for tracing purpose #23574

Open
MartinForReal opened this issue Oct 14, 2024 · 2 comments
Open

Expose track2 module name and version for tracing purpose #23574

MartinForReal opened this issue Oct 14, 2024 · 2 comments
Labels
CodeGen Issues that relate to code generation customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@MartinForReal
Copy link
Contributor

Feature Request

Expose track2 module name and version for tracing purpose

We need to add module info into trace context. But Module name and module version are not exposed to public.

e.g.

azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/constants.go

Line 12 in fb9b7a2

moduleName = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute"

Do you think if it is feasible to expose those information? Thanks!
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 14, 2024
@lirenhe
Copy link
Member

lirenhe commented Oct 14, 2024

@jhendrixMSFT, could you comment on this ask? Is it by design that we don't expose name & version?

@jhendrixMSFT jhendrixMSFT added CodeGen Issues that relate to code generation feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 14, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Oct 14, 2024
@jhendrixMSFT
Copy link
Member

The only reason we never exported it in the past was because we didn't think it would be useful. If there's a real need for these to be exported, we can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CodeGen Issues that relate to code generation customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinForReal @lirenhe @jhendrixMSFT