Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Update dependencies for Microsoft.Extensions.Azure in Packages.Data.props #47363

Open
JonathanCrd opened this issue Nov 27, 2024 · 6 comments
Labels
Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions

Comments

@JonathanCrd
Copy link
Member

As part of #47286, we had to override some dependencies to bump them into the v8.0 for the following packages:

  • Azure.Extensions.AspNetCore.DataProtection.Blobs
  • Azure.Extensions.AspNetCore.DataProtection.Keys
  • Microsoft.Extensions.Azure

Now that we have released those SDKs, we can bump the dependencies centrally in Packages.Data.props

@JonathanCrd JonathanCrd added the Extensions ASP.NET Core extensions label Nov 27, 2024
@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Nov 28, 2024
@Y-Sindo
Copy link
Member

Y-Sindo commented Dec 26, 2024

Hello, do we have an ETA of when this could be finished? This would help to resolve a dependency downgraded issue in my PR build.

azure-pipelines
/ net - signalr - ci (Build Test MacOS_NET80_ProjectRef_Release)
sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj#L0

sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj(0,0): Error NU1605: Warning As Error: Detected package downgrade: Microsoft.Bcl.AsyncInterfaces from 8.0.0 to 6.0.0. Reference the package directly from the project to select a different version.
Microsoft.Azure.WebJobs.Extensions.SignalRService -> Microsoft.Extensions.Azure -> Microsoft.Bcl.AsyncInterfaces (>= 8.0.0)
Microsoft.Azure.WebJobs.Extensions.SignalRService -> Microsoft.Bcl.AsyncInterfaces (>= 6.0.0)

@JonathanCrd
Copy link
Member Author

I believe @jsquire had this PR open to tackle this issue:

@jsquire
Copy link
Member

jsquire commented Jan 6, 2025

This one will need to go first: #47542

@jsquire
Copy link
Member

jsquire commented Jan 6, 2025

Hello, do we have an ETA of when this could be finished? This would help to resolve a dependency downgraded issue in my PR build.

azure-pipelines
/ net - signalr - ci (Build Test MacOS_NET80_ProjectRef_Release)
sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj#L0
sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj(0,0): Error NU1605: Warning As Error: Detected package downgrade: Microsoft.Bcl.AsyncInterfaces from 8.0.0 to 6.0.0. Reference the package directly from the project to select a different version.
Microsoft.Azure.WebJobs.Extensions.SignalRService -> Microsoft.Extensions.Azure -> Microsoft.Bcl.AsyncInterfaces (>= 8.0.0)
Microsoft.Azure.WebJobs.Extensions.SignalRService -> Microsoft.Bcl.AsyncInterfaces (>= 6.0.0)

@Y-Sindo: Sounds like you've got a direct reference to Microsoft.Bcl.AsyncInterfaces in your project, which you should remove.

@Y-Sindo
Copy link
Member

Y-Sindo commented Jan 9, 2025

Sounds like you've got a direct reference to Microsoft.Bcl.AsyncInterfaces in your project, which you should remove.

@jsquire Thanks. I've passed the build by removing the direct reference.

@svrooij
Copy link

svrooij commented Jan 27, 2025

@Y-Sindo everything above dotnet 3.1 does not need Microsoft.Bcl.AsyncInterfaces would it be possible to remove that all together from all Azure libraries?

And starting with dotnet 6, you don't need a reference to System.Text.Json, System.Net.Http, System.Memory.Data, System.Numerics.Vectors

So for Azure.Core targetting dotnet6/9 all these requirements can should be removed:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions
Projects
None yet
Development

No branches or pull requests

4 participants