You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Occurs when a PR contains changes in multiple packages. Especially when those changes are made incrementally with multiple commits
Detect-API-Change step fires multiple calls to APIView for the various packages
One single package that does not have an existing pull request will cause the entire PR comment to be over written.
Occurs when a PR contains changes in multiple packages. Especially when those changes are made incrementally with multiple commits
Detect-API-Change step fires multiple calls to APIView for the various packages
One single package that does not have an existing pull request will cause the entire PR comment to be over written.
The issue starts at
azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Managers/PullRequestManager.cs
Lines 73 to 89 in d784f16
If no pullRequestModel is found for the package it will create a new pullRequestModel with no APIRevisionId (Line 78)
The presence of APIRevisionId determines if we fetch pullRequest information
azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Controllers/PullRequestController.cs
Line 161 in d784f16
Then we later check there is any pr info
azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Managers/PullRequestManager.cs
Line 97 in d784f16
This leads to all the packages in the PR being marked as having no changes even though its just one package
azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Managers/PullRequestManager.cs
Lines 110 to 113 in d784f16
The text was updated successfully, but these errors were encountered: