Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIView] feature to highlight handwritten/patched code #9890

Open
swathipil opened this issue Feb 21, 2025 · 2 comments
Open

[APIView] feature to highlight handwritten/patched code #9890

swathipil opened this issue Feb 21, 2025 · 2 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@swathipil
Copy link
Member

This would help us see whether changes need to be made to the emitters, the spec, or the patched code.

Options for vizualization:

  • Diagnostic bannner that says "patched" or something similar
  • Something that could be toggled on and would highlight the handwritten code in a color
@swathipil swathipil added the feature-request This issue requires a new behavior in the product in order be resolved. label Feb 21, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Feb 21, 2025
@praveenkuttappan praveenkuttappan added Central-EngSys This issue is owned by the Engineering System team. APIView labels Feb 21, 2025
@praveenkuttappan
Copy link
Member

@swathipil How do you identify patched or handwritten code? Is this something Python API parser can identify and set a flag?

It is possible that you can add a new style class name for handwritten code and UI can have different css to highlight them. @chidozieononiwu Please correct me if I am wrong.

We can also definitely add a new toggler in UI to find or highlight them.

@swathipil
Copy link
Member Author

In Python, handwritten code is added to a _patch file so it's something that we can identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Status: 🆕 New
Status: 🤔 Triage
Development

No branches or pull requests

3 participants