Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PR Relink Button After Milestone Completion in Management Plane API Readiness #9930

Open
MrJustinB opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience

Comments

@MrJustinB
Copy link
Member

Issue Summary:

The issue involves the management plane API readiness process where the link button remains enabled on the "associate Pull Request task", allowing users to update PR link even after the milestone is marked as complete. This leads to inconsistencies in the state of the release plan.

Solution Discussed:

Disable the button to relink the PR once the milestone is completed to prevent further modifications.
Alternatively, if a new PR is added, reset the entire state of the milestone, not just the individual steps, to ensure consistency.

Key Points:

The button should be disabled once the milestone is completed to avoid revalidation and ensure the PR used for SDK generation is final.
If a new PR is added, reset the entire milestone state to maintain consistency.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 26, 2025
@MrJustinB MrJustinB moved this from New to Backlog in Engagement Experience Feb 26, 2025
@MrJustinB MrJustinB added Central-EngSys This issue is owned by the Engineering System team. Engagement Experience and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 26, 2025
@maririos
Copy link
Member

I will add, the api readiness milestone can't be completed until the PR is merged somewhere (a branch in the private repo for private preview) and in main of the public repo for `public preview, and GA)

@maririos
Copy link
Member

@MrJustinB given the High priority, we will try to add it to our next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience
Projects
Status: 🤔 Triage
Status: Backlog
Development

No branches or pull requests

2 participants