From 87ca110fc044ca7cce107a09a0eeb2590db26b76 Mon Sep 17 00:00:00 2001 From: Shenglong Li Date: Wed, 12 Jul 2023 14:54:15 -0700 Subject: [PATCH] Fix linting issue in official build (#11215) ###### Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11215&drop=dogfoodAlpha --- .github/workflows/build.yml | 3 +++ src/Bicep.MSBuild.E2eTests/src/example.ts | 12 ++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0c0d7ad7d72..06bab096f5e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -337,10 +337,13 @@ jobs: include: - os: windows-latest rid: win-x64 + runTests: true - os: ubuntu-latest rid: linux-x64 + runTests: true - os: macos-latest rid: osx-x64 + runTests: true - os: ubuntu-latest rid: win-arm64 runTests: false diff --git a/src/Bicep.MSBuild.E2eTests/src/example.ts b/src/Bicep.MSBuild.E2eTests/src/example.ts index 09dcb60eba5..b4da6ad5f8e 100644 --- a/src/Bicep.MSBuild.E2eTests/src/example.ts +++ b/src/Bicep.MSBuild.E2eTests/src/example.ts @@ -11,12 +11,12 @@ export class Example { constructor(projectName: string, projectFile?: string) { const projectDir = path.normalize( - path.join(__dirname, `../examples/${projectName}/`) + path.join(__dirname, `../examples/${projectName}/`), ); this.projectDir = projectDir; this.projectFile = path.join( projectDir, - projectFile ?? `${projectName}.proj` + projectFile ?? `${projectName}.proj`, ); } @@ -42,7 +42,7 @@ export class Example { public publish( targetFramework: string | null, - expectSuccess = true + expectSuccess = true, ): SpawnSyncReturns { return this.runMsBuild("publish", targetFramework, expectSuccess); } @@ -76,12 +76,12 @@ export class Example { private runMsBuild( verb: string, targetFramework: string | null, - expectSuccess: boolean + expectSuccess: boolean, ): SpawnSyncReturns { const runtimeSuffix = process.env.RuntimeSuffix; if (!runtimeSuffix) { throw new Error( - "Please set the RuntimeSuffix environment variable to a .net runtime ID to run these tests. Possible values: win-x64, linux-x64, osx-x64" + "Please set the RuntimeSuffix environment variable to a .net runtime ID to run these tests. Possible values: win-x64, linux-x64, osx-x64", ); } const result = spawn.sync( @@ -98,7 +98,7 @@ export class Example { cwd: this.projectDir, stdio: "pipe", encoding: "utf-8", - } + }, ); if (expectSuccess && result.status !== 0) {