We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests should be fast but https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/dev/apps/tests/performance/performance_test.go does performance testing using homegrown . The test runs so long it times out on my computer.
Better would be to use Go's built-in benchmark feature https://pkg.go.dev/testing#hdr-Benchmarks . This has advantages:
There are standard tools for working with benchmark results at https://golang.org/x/perf/cmd. In particular, https://golang.org/x/perf/cmd/benchstat performs statistically robust A/B comparisons.
This would also remove the dependency on github.com/montanaflynn/stats
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Unit tests should be fast but https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/dev/apps/tests/performance/performance_test.go does performance testing using homegrown . The test runs so long it times out on my computer.
Better would be to use Go's built-in benchmark feature https://pkg.go.dev/testing#hdr-Benchmarks . This has advantages:
This would also remove the dependency on github.com/montanaflynn/stats
The text was updated successfully, but these errors were encountered: