Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MSAL is failing to parse an error response from the server #860

Open
Avery-Dunn opened this issue Aug 29, 2024 · 0 comments
Open

[Bug] MSAL is failing to parse an error response from the server #860

Avery-Dunn opened this issue Aug 29, 2024 · 0 comments
Labels
Bug Something isn't working, needs an investigation and a fix confidential-client For issues related to confidential client apps P2 Normal priority items, should be done after P1 public-client For questions/issues related to public client apps Supportability For issues related to improving the customer support experience

Comments

@Avery-Dunn
Copy link
Contributor

Library version used

1.17.0

Java version

8

Scenario

Other - please specify

Is this a new or an existing app?

The app is in production, I haven't upgraded MSAL, but started seeing this issue

Issue description and reproduction steps

A JSON parser is used to extract error messages and other info from responses. However, it appears that some unexpected format is being sent for some errors, such as when there are too many requests:

We need to investigate why these responses aren't getting parsed, and ensure that error messages are correctly relayed from the server to the customer and MSAL provides provide meaningful messages.

Relevant code snippets

`com.microsoft.aad.msal4j.MsalClientException: com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'Too': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
at [Source: (String)"Too Many Requests"; line: 1, column: 4]`

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response

@Avery-Dunn Avery-Dunn added Bug Something isn't working, needs an investigation and a fix public-client For questions/issues related to public client apps confidential-client For issues related to confidential client apps labels Aug 29, 2024
@bgavrilMS bgavrilMS added P2 Normal priority items, should be done after P1 Supportability For issues related to improving the customer support experience labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working, needs an investigation and a fix confidential-client For issues related to confidential client apps P2 Normal priority items, should be done after P1 public-client For questions/issues related to public client apps Supportability For issues related to improving the customer support experience
Projects
None yet
Development

No branches or pull requests

2 participants