Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement checker CLI #12

Open
JosePizarro3 opened this issue Dec 10, 2024 · 3 comments
Open

Implement checker CLI #12

JosePizarro3 opened this issue Dec 10, 2024 · 3 comments
Assignees
@carlosmada22
Labels
enhancement New feature or request question Further information is requested schema Masterdata schema template defined in openBIS

Comments

@JosePizarro3
Copy link
Contributor

In order to compare classes in Python, it is enough implementing the dunder methods __eq__ and __ne__:

  • At the entities.py level
  • Trying to keep everything at the BaseEntity level (when possible)
@JosePizarro3 JosePizarro3 added enhancement New feature or request schema Masterdata schema template defined in openBIS labels Dec 10, 2024
@JosePizarro3 JosePizarro3 added the question Further information is requested label Dec 10, 2024
@JosePizarro3
Copy link
Contributor Author

Maybe this is not necessary, as out of the box it is easy to compare classes by using == and !=

@JosePizarro3
Copy link
Contributor Author

I saw Cagtay has something similar for OpenbisSchema and he defined a few methods for this.

@JosePizarro3 JosePizarro3 changed the title Implement eq and ne Implement checker CLI Jan 13, 2025
@JosePizarro3
Copy link
Contributor Author

JosePizarro3 commented Jan 13, 2025 •
edited
Loading

Implement after

This was referenced Jan 13, 2025
Closed
Closed
@JosePizarro3 JosePizarro3 mentioned this issue Jan 29, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosmada22 carlosmada22

Labels
enhancement New feature or request question Further information is requested schema Masterdata schema template defined in openBIS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosmada22 @JosePizarro3