You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to set ylims for the utci_day_comfort_metrics plot type (usually accessed via the ExternalComfort object), the axes added to this figure would need to each be individually access in order to modify these properties. In doing so, the plot getas a bit messed up and doesn't look as nice.
Merely exposing the ylims and variable-specific axes for this output would make it possible to fix the limits and ensure the plot gets generated correctly - without the need to hack apart something which mostly works.
Description:
In order to set ylims for the
utci_day_comfort_metrics
plot type (usually accessed via the ExternalComfort object), the axes added to this figure would need to each be individually access in order to modify these properties. In doing so, the plot getas a bit messed up and doesn't look as nice.Merely exposing the ylims and variable-specific axes for this output would make it possible to fix the limits and ensure the plot gets generated correctly - without the need to hack apart something which mostly works.
The method can be found here:
LadybugTools_Toolkit/LadybugTools_Engine/Python/src/ladybugtools_toolkit/plot/_utci.py
Line 143 in 5999708
Steps to reproduce:
Here is some code which does what we're trying to do ... but poorly
And this is what it generated, with the dodgy additional axes:
![image](https://private-user-images.githubusercontent.com/10939984/289559988-bf6cbd9b-222f-4111-a219-19449ee3600f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NDI0NTgsIm5iZiI6MTczODk0MjE1OCwicGF0aCI6Ii8xMDkzOTk4NC8yODk1NTk5ODgtYmY2Y2JkOWItMjIyZi00MTExLWEyMTktMTk0NDllZTM2MDBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE1MjkxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiMzM3MGI0NjJlZjk1YWE2NzY4MTVmY2I1Yjk5NjI0YmJiZDY5Yzk4NWJiZjQ4OTRkMGFlZjQxMzljYTI3MWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AeHNxViITORTATbq1j3EqrxCDCSt2OzbohLI8lFJWMc)
Expected behaviour:
ylims
as additional args/kwargs to the plot method, also accessible from the ExternalComfort object which calls it.Test file(s):
The text was updated successfully, but these errors were encountered: