Data should eventually be randomized from pooled data sets #2

coder4life · 2017-09-11T23:35:17Z

test-runner/tests/access/community/wow/achievements/retrieve-achievement.js

Line 27 in 13ebf4a

requestObject () {

Data should be randomized for data sets. There are some good "Faker" data classes that can provide some filler objects that get mapped to a set of data pool.

Potential fix for issue #2

4lch4 · 2017-09-17T05:12:20Z

What about like in 6b2532c, is that what you had in mind?

Instead of the entire faker.js module, we could use the DataGenerator which allows us to create methods such as region() which return values the Battle.net API expect.

4lch4 added a commit that referenced this issue Sep 17, 2017

Added faker

6b2532c

Potential fix for issue #2

4lch4 referenced this issue Sep 22, 2017

Replaced Faker with own DataGenerator

ae15d50

Instead of the entire faker.js module, we could use the DataGenerator which allows us to create methods such as region() which return values the Battle.net API expect.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data should eventually be randomized from pooled data sets #2

Data should eventually be randomized from pooled data sets #2

coder4life commented Sep 11, 2017

4lch4 commented Sep 17, 2017

Data should eventually be randomized from pooled data sets #2

Data should eventually be randomized from pooled data sets #2

Comments

coder4life commented Sep 11, 2017

4lch4 commented Sep 17, 2017