Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated deferOnce, defer and setTimeout #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove deprecated deferOnce, defer and setTimeout #290

wants to merge 1 commit into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Dec 4, 2017

I think they have been deprecated enough to remove them, and since they are not used in ember for long time

@bekzod bekzod force-pushed the remove-depricated branch from 3ede4f7 to 8583461 Compare December 4, 2017 05:54
rwjblue
rwjblue reviewed Dec 4, 2017
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the tests/defer-once-test.jsalso?

@bekzod bekzod force-pushed the remove-depricated branch 4 times, most recently from 57c7e51 to 941520d Compare December 4, 2017 16:38
@bekzod
Copy link
Contributor Author

bekzod commented Dec 4, 2017

done

@bekzod
Copy link
Contributor Author

bekzod commented Jan 4, 2018

this is ready for merge 😉

@bekzod bekzod force-pushed the remove-depricated branch from 941520d to 9e0aa8e Compare January 20, 2018 13:14
@bekzod
Copy link
Contributor Author

bekzod commented Jan 20, 2018

rebased again, ping ping

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 21, 2018

ya, we just need to land this before the next major, which should be soonish (after #306 lands)...

@bekzod bekzod force-pushed the remove-depricated branch from 9e0aa8e to 67cc051 Compare May 22, 2018 15:27
@bekzod
Copy link
Contributor Author

bekzod commented May 22, 2018

this is also ready to merge

@bekzod
Copy link
Contributor Author

bekzod commented Jun 7, 2018

ping

@rwjblue
Copy link
Collaborator

rwjblue commented Jun 7, 2018

We can only merge this when we are ready to do a major bump.

@bekzod
Copy link
Contributor Author

bekzod commented Jun 7, 2018

what is stoping merging and doing major bump :P

@bekzod
Copy link
Contributor Author

bekzod commented Aug 19, 2018

maybe it is time remove this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekzod @rwjblue