You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in Bankless Loans we are not following Chakra UI best-practices when it comes to use of Chakra components and theming.
This issue would be to 1) create Button themes that match the new design, and (2) add those new theme styles to the existing buttons in the existing forms.
Looking at the Figma - I do not see a dark grey Claim button that OverAchiever and IsraelRex created. Currently am seeing all purple Claim buttons - I asked IsraelRex in Bankless Loans.
Additionally, it might makes sense to implement some sort of "ButtonGroup" variant within the theme that would handle the layout of two buttons (side-by-side). Currently there is a "layout.actions" variant named in the TSX but not implemented in chakra theme that might be an option for this "ButtonGroup" variant.
Currently in the Stability Pool form we display 3 buttons in that form. I would say to add the design to the existing buttons. Let's create a separate issue for the following: the idea being that a user would click on a single "Claim" button, and then two Claim buttons would render with each option (see Stability Pool route to see those 2 claim options today).
Given that the new form layout has not yet been implemented - it might be tricky to size the buttons as per the figma file. To get around that, my first thought is give the buttons an auto width to scale to their container. But if that existing form width is a blocker for the button width then message Birdman for another task.
Time required for this task is estimated roughly 4 to 8 hours. Keep track of your time.
The text was updated successfully, but these errors were encountered:
Currently in Bankless Loans we are not following Chakra UI best-practices when it comes to use of Chakra components and theming.
This issue would be to 1) create Button themes that match the new design, and (2) add those new theme styles to the existing buttons in the existing forms.
Looking at the Figma - I do not see a dark grey Claim button that OverAchiever and IsraelRex created. Currently am seeing all purple Claim buttons - I asked IsraelRex in Bankless Loans.
Additionally, it might makes sense to implement some sort of "ButtonGroup" variant within the theme that would handle the layout of two buttons (side-by-side). Currently there is a "layout.actions" variant named in the TSX but not implemented in chakra theme that might be an option for this "ButtonGroup" variant.
Currently in the Stability Pool form we display 3 buttons in that form. I would say to add the design to the existing buttons. Let's create a separate issue for the following: the idea being that a user would click on a single "Claim" button, and then two Claim buttons would render with each option (see Stability Pool route to see those 2 claim options today).
Given that the new form layout has not yet been implemented - it might be tricky to size the buttons as per the figma file. To get around that, my first thought is give the buttons an auto width to scale to their container. But if that existing form width is a blocker for the button width then message Birdman for another task.
Time required for this task is estimated roughly 4 to 8 hours. Keep track of your time.
The text was updated successfully, but these errors were encountered: