From 89a27efb65cdaed76b5433ee2e2a2f4738525bac Mon Sep 17 00:00:00 2001 From: Bart Vandewoestyne Date: Mon, 12 Feb 2024 22:30:57 +0100 Subject: [PATCH] Improve linking for builder1 and builder2. The creational_patterns library is required for the builder library, but this was not specified yet. It is now added as a PUBLIC link library for builder and because of that, we no longer need to specify it as a linker library for builder1 and builder2. --- Creational_Patterns/Builder/CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Creational_Patterns/Builder/CMakeLists.txt b/Creational_Patterns/Builder/CMakeLists.txt index 5d364ec..3b27964 100644 --- a/Creational_Patterns/Builder/CMakeLists.txt +++ b/Creational_Patterns/Builder/CMakeLists.txt @@ -5,9 +5,10 @@ set(builder_SRCS add_library(builder SHARED ${builder_SRCS}) target_include_directories(builder PUBLIC ../) +target_link_libraries(builder PUBLIC creational_patterns) add_executable(builder1 builder1.cpp) add_executable(builder2 builder2.cpp) -target_link_libraries(builder1 builder creational_patterns) -target_link_libraries(builder2 builder creational_patterns) +target_link_libraries(builder1 PRIVATE builder) +target_link_libraries(builder2 PRIVATE builder)