Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fn::Equals accept any Token type #173

Open
jfklingler opened this issue Jun 23, 2017 · 0 comments
Open

Make Fn::Equals accept any Token type #173

jfklingler opened this issue Jun 23, 2017 · 0 comments

Comments

@jfklingler
Copy link
Contributor

The docs say

value
    A value of any type that you want to compare.

So I believe that Fn::Equals should support more than just String arguments. I haven't tried to make this change and I can't quite resolve all of the types in my head, but I think we should be able to do something along the lines of

case class `Fn::Equals`[T](a: Token[T], b: Token[T])
  extends NestableAmazonFunctionCall[String]("Fn::Equals")
{type CFBackingType = (Token[T], Token[T]) ; val arguments = (a, b)}

I suspect there will be troubles with the serialization though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant