Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git submodules #279

Open
SmokeyStack opened this issue Jan 6, 2024 · 1 comment
Open

Support git submodules #279

SmokeyStack opened this issue Jan 6, 2024 · 1 comment

Comments

@SmokeyStack
Copy link
Member

It would be great if a flag was added or set to default that would pull git submodules when installing a filter

@stirante
Copy link
Member

stirante commented Jan 7, 2024

I think it should by default try to fetch submodules.

Seems like here we should add --recurse-submodules --j8 flags
https://github.com/Bedrock-OSS/regolith/blob/main/regolith/filter_remote.go#L438

And here should be another git command git submodule update --init --recursive
https://github.com/Bedrock-OSS/regolith/blob/main/regolith/filter_remote.go#L486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants