Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regolith install is overwriting old filters #58

Closed
SirLich opened this issue Oct 10, 2021 · 1 comment
Closed

Regolith install is overwriting old filters #58

SirLich opened this issue Oct 10, 2021 · 1 comment
Assignees
@SirLich
Labels
bug Something isn't working
Milestone
0.0.x Next Minor

Comments

@SirLich
Copy link
Contributor

SirLich commented Oct 10, 2021

This is a massive issue for three reasons:

  • The new logic for data folder could cause dataloss if the filter is auto-reinstalled
  • If somebody adds a new filter, and then calls 'regolith install', they will reinstall everything, which could take some time.
  • Users could accidentally get an updated version of a filter, when they wanted to stay on old version.

Relates to #48

The way this would work is via a regolith install --update command, I guess. Or something similar.
@SirLich SirLich added the bug Something isn't working label Oct 10, 2021
@SirLich SirLich mentioned this issue Oct 10, 2021
Closed
@SirLich SirLich added this to the 0.0.x Next Minor milestone Oct 10, 2021
@SirLich SirLich self-assigned this Oct 11, 2021
@SirLich
Copy link
Contributor Author

SirLich commented Oct 11, 2021

Fixed

@SirLich SirLich closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirLich SirLich

Labels
bug Something isn't working
Projects
None yet
Milestone
0.0.x Next Minor
Development

No branches or pull requests
1 participant
@SirLich