Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to iSendARequestWithFormData #57

Open
andyOstrava opened this issue Jul 7, 2016 · 0 comments
Open

Improvement to iSendARequestWithFormData #57

andyOstrava opened this issue Jul 7, 2016 · 0 comments

Comments

@andyOstrava
Copy link

Hi!

The Web API Extension is exactly what I was looking for and has been a huge help. When I tried to use iSendARequestWithFormData, however, I found that it was losing any headers I had already added.

I wanted to suggest something like the following at line 198:

        $this->addHeader('Content-Type', 'application/x-www-form-urlencoded');
        $this->request = new Request($method, $url, $this->headers, http_build_query($fields, null, '&'));

Is that reasonable? Many apologies if I'm missing something.

andyOstrava added a commit to andyOstrava/BehatWebApiExtension that referenced this issue Sep 6, 2016
andyOstrava added a commit to andyOstrava/BehatWebApiExtension that referenced this issue Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant