Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI #172

Open
wants to merge 3 commits into
base: restart
Choose a base branch
from
Open

UI #172

wants to merge 3 commits into from

Conversation

GauravKarakoti
Copy link

@GauravKarakoti GauravKarakoti commented Feb 5, 2025

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

@techy4shri techy4shri requested a review from BhattAnsh February 5, 2025 14:01
@GauravKarakoti
Copy link
Author

@BhattAnsh please review this pr

@BhattAnsh
Copy link
Owner

@GauravKarakoti Why you added nav component in layout directly create a component then import it there.
Also make sure for ui tasks attach images of ui from your side so it will be easy for us to review.

Also make sure its responsive.

@GauravKarakoti
Copy link
Author

@GauravKarakoti Why you added nav component in layout directly create a component then import it there.
Also make sure for ui tasks attach images of ui from your side so it will be easy for us to review.

Also make sure its responsive.

Hi sure I'll do the necessary changes , also can you please provide me that side image png from the reference images provided in the issue , I'd also add it there

@GauravKarakoti
Copy link
Author

You can check now @BhattAnsh

Screenshot 2025-02-06 185827
Screenshot 2025-02-06 190841

You just need to switch the image URL for the right image , I didn't had the desired image so I added google one temporarily

@BhattAnsh
Copy link
Owner

@GauravKarakoti background is good and regarding the ui what don't you think the input fields are too small and also there are so much empty spaces I am attaching the SVG for the login page but experiment a little and use ui libraries make it look more consistent in design. u can use a subtle pattern in the background which fills up the screen but do not interfere with the input and other design in short "experiment a little this ui is not great"
login svg

@GauravKarakoti
Copy link
Author

GauravKarakoti commented Feb 7, 2025

image

How does this look? @BhattAnsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Login/Signup Page
2 participants