More testing adaptions

.pre-commit-config.yaml

@@ -20,8 +20,6 @@ repos:
       - id: mypy
         name: mypy
         files: ^(?!(tests|changes)).*\.py$
-        args:
-          - --enable-incomplete-feature=NewGenericSyntax
         additional_dependencies:
           - .
           - pydantic-settings~=2.3

changes/unreleased/0064.TcBysgmjU9HuXcCNtAmXnp.toml

@@ -1,4 +1,5 @@
 features = "Add Classes :class:`~chango.concrete.BackwardCompatibleVersionScanner` and :class:`~chango.concrete.BackwardCompatibleChanGo` allowing to easily transition between change not formats"
+breaking = "Adapt expected exceptions in :class:`~chango.abc.ChanGo` and :class:`~chango.abc.VersionScanner` to use :class:`~chango.error.ChanGoError`"
 internal = "Switch to using :class:`~chango.concrete.sections.GitHubSectionChangeNote`"
 [[pull_requests]]
 uid = "64"

src/chango/abc/_chango.py

@@ -183,7 +183,7 @@ def load_version_note(self, version: VUIDInput) -> VNT:
             :class:`VNT <typing.TypeVar>`: The loaded :class:`~chango.abc.VersionNote`.
 
         Raises:
-            ValueError: If the version is not available.
+            ~chango.error.ChanGoError: If the version is not available.
         """
         changes = self.scanner.get_changes(version)
         version_obj = self.scanner.get_version(version) if isinstance(version, str) else version

src/chango/abc/_versionscanner.py

@@ -7,6 +7,7 @@
 from .._changenoteinfo import ChangeNoteInfo
 from .._utils.types import VUIDInput
 from .._version import Version
+from ..error import ChanGoError
 
 
 class VersionScanner(Collection[Version]):
@@ -112,12 +113,12 @@ def get_version(self, uid: str) -> Version:
             :class:`~chango.Version`: The version.
 
         Raises:
-            ValueError: If the version with the given identifier is not available.
+            ~chango.error.ChanGoError: If the version with the given identifier is not available.
         """
         try:
             return next(version for version in self if version.uid == uid)
         except StopIteration as exc:
-            raise ValueError(f"Version '{uid}' not available.") from exc
+            raise ChanGoError(f"Version '{uid}' not available.") from exc
 
     @abc.abstractmethod
     def get_changes(self, uid: VUIDInput) -> tuple[str, ...]:

src/chango/concrete/_directorychango.py

@@ -7,6 +7,7 @@
 from .._utils.types import VUIDInput
 from ..abc import ChangeNote, ChanGo, VersionHistory, VersionNote
 from ..action import ChanGoActionData
+from ..error import ChanGoError
 from ._directoryversionscanner import DirectoryVersionScanner
 from .sections import SectionChangeNote, SectionVersionNote
 
@@ -93,8 +94,8 @@ def get_write_directory(self, change_note: CNT | str, version: VUIDInput) -> Pat
             if isinstance(version, str):
                 try:
                     version_obj = self.scanner.get_version(version)
-                except ValueError as exc:
-                    raise TypeError(
+                except ChanGoError as exc:
+                    raise ChanGoError(
                         f"Version '{version}' not available yet. To get the write directory for a "
                         "new version, pass the version as `change.Version` object."
                     ) from exc

tests/abc/test_versionscanner.py

@@ -8,6 +8,7 @@
 from chango import Version
 from chango.abc import VersionScanner
 from chango.concrete import DirectoryVersionScanner
+from chango.error import ChanGoError
 from tests.auxil.files import data_path
 
 
@@ -81,7 +82,7 @@ def test_get_version(self, scanner, idx):
         assert version.date == dtm.date(2024, 1, idx)
 
     def test_get_version_not_found(self, scanner):
-        with pytest.raises(ValueError, match="not available"):
+        with pytest.raises(ChanGoError, match="not available"):
             scanner.get_version("1.4")
 
     def test_invalidates_caches(self, scanner):