Fix A Bug in GitHubSectionChangeNot.get_thread_url

[Bibo-Joshi]

closes #71

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
442	1	441	1

View the top 1 failed test(s) by shortest run time

tests.concrete.sections.test_sectionversionnote.TestSectionVersionNote::test_render

Stack Traces | 0.007s run time

self = <tests.concrete.sections.test_sectionversionnote.TestSectionVersionNote object at 0x000002759261C200>
section_version_note = <chango.concrete.sections._sectionversionnote.SectionVersionNote object at 0x0000027594A84E00>

        def test_render(self, section_version_note):
            section_version_note.add_change_note(
                DummySectionChangeNote(
                    slug="slug1",
                    uid="uid1",
                    req_section="change note 1 req.\nWith multiple lines.",
                    opt_section="change note 1 opt.",
                    pull_requests=[
                        PullRequest(
                            uid="pr1", closes_threads=("thread1", "thread2"), author_uid="author1"
                        ),
                        PullRequest(uid="pr2", author_uid="author2"),
                    ],
                )
            )
            section_version_note.add_change_note(
                DummySectionChangeNote(slug="slug2", uid="uid2", req_section="change note 2 req.")
            )
            section_version_note.add_change_note(
                DummySectionChangeNote(
                    slug="slug3",
                    uid="uid3",
                    req_section="change note 3 req.",
                    pull_requests=[PullRequest(uid="pr_a", author_uid="author_b")],
                )
            )
>           assert (
                section_version_note.render("rst")
                == """\
    Optional Section
    ----------------
    
    - change note 1 opt.
    
    Required Section
    ----------------
    
    - change note 1 req.
    
      With multiple lines.
    
      (`#pr1 <https://github..../my-repo/pull/pr1>`_ by `@author1 \
    <https://github.com/author1>`_ closes `#thread1 \
    <https://github..../my-repo/issue/thread1>`_, `#thread2 \
    <https://github..../my-repo/issue/thread2>`_; `#pr2 \
    <https://github..../my-repo/pull/pr2>`_ by `@author2 <https://github.com/author2>`_)
    - change note 2 req.
    - change note 3 req. (`#pr_a <https://github..../my-repo/pull/pr_a>`_ by \
    `@author_b <https://github.com/author_b>`_)\
    """
            )
E           AssertionError: assert 'Optional Sec.../author_b>`_)' == 'Optional Sec.../author_b>`_)'
E             
E               Optional Section
E               ----------------
E               
E               - change note 1 opt.
E               
E               Required Section
E               ----------------
E               
E               - change note 1 req.
E               
E                 With multiple lines.
E               
E             -   (`#pr1 <https://github..../my-repo/pull/pr1>`_ by `@author1 <https://github.com/author1>`_ closes `#thread1 <https://github..../my-repo/issue/thread1>`_, `#thread2 <https://github..../my-repo/issue/thread2>`_; `#pr2 <https://github..../my-repo/pull/pr2>`_ by `@author2 <https://github.com/author2>`_)
E             +   (`#pr1 <https://github..../my-repo/pull/pr1>`_ by `@author1 <https://github.com/author1>`_ closes `#thread1 <https://github..../my-repo/issues/thread1>`_, `#thread2 <https://github..../my-repo/issues/thread2>`_; `#pr2 <https://github..../my-repo/pull/pr2>`_ by `@author2 <https://github.com/author2>`_)
E             ?                                                                                                                                                                        +                                                                    +
E               - change note 2 req.
E               - change note 3 req. (`#pr_a <https://github..../my-repo/pull/pr_a>`_ by `@author_b <https://github.com/author_b>`_)

tests\concrete\sections\test_sectionversionnote.py:87: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}