Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to D3V6 #8

Open
Fallstop opened this issue Jan 1, 2021 · 11 comments
Open

Upgrading to D3V6 #8

Fallstop opened this issue Jan 1, 2021 · 11 comments

Comments

@Fallstop
Copy link

Fallstop commented Jan 1, 2021

The latest version of cubism-es is incompatible with the latest D3 library version realised last September, namely one of the issues is the API change around d3-selection new event manager (d3.mouse -> d3.pointer).

Is there a plan to upgrade?
If wanted, I can submit a pull request with the changes necessary to both the library and demos.

@Fallstop
Copy link
Author

Fallstop commented Jan 4, 2021

Because of the lack of activity, I'll just go ahead and attempt to do it myself.

@BigFatDog
Copy link
Owner

Thank you. Once you make a pull request I'll merge it.

@aspiers
Copy link

aspiers commented Feb 19, 2021

Any update on this @Fallstop? I'd be happy to test.

@Fallstop
Copy link
Author

Sorry! Completely forgot about this. It's mostly done as there was not a lot of API changes, but my testing method is very jank. Is there an example repo that I could use to test the changes?

@aspiers
Copy link

aspiers commented Feb 20, 2021

You can presumably use the demos in this repo: https://github.com/BigFatDog/cubism-es/tree/master/demo

@Fallstop
Copy link
Author

That's what I thought too. But those are all using DISCRETE CUBISM.JS, a modified version of the original cubism, and don't use cubism-es.

@aspiers
Copy link

aspiers commented Feb 20, 2021

That's not correct:

  1. Only demo/discrete-cubism.html is using demo/discrete-cubism.js; none of the others are.
  2. demo/discrete-cubism.js is not a modified version of the original cubism, it's some code specific to the discrete-cubism demo, and that demo, like all the others uses cubism-es:

<script src="./cubism-es.standalone.js"></script>

@throrin19
Copy link

Any news ?

@mpatou
Copy link

mpatou commented Feb 29, 2024

@Fallstop can you push your work in progress in your repo ?

@ekacnet
Copy link

ekacnet commented Mar 10, 2024

I made a few commits in my fork to:

I don't know how much @BigFatDog is still active on this project if not active I might end up publishing something on npm on my own.

@ekacnet
Copy link

ekacnet commented Mar 18, 2024

All my changes are available in my dev branch on: https://github.com/ekacnet/cubism-es/tree/dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants