-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to D3V6 #8
Comments
Because of the lack of activity, I'll just go ahead and attempt to do it myself. |
Thank you. Once you make a pull request I'll merge it. |
Any update on this @Fallstop? I'd be happy to test. |
Sorry! Completely forgot about this. It's mostly done as there was not a lot of API changes, but my testing method is very jank. Is there an example repo that I could use to test the changes? |
You can presumably use the demos in this repo: https://github.com/BigFatDog/cubism-es/tree/master/demo |
That's what I thought too. But those are all using |
That's not correct:
cubism-es/demo/discrete-cubism.html Line 20 in c8dd327
|
Any news ? |
@Fallstop can you push your work in progress in your repo ? |
I made a few commits in my fork to:
I don't know how much @BigFatDog is still active on this project if not active I might end up publishing something on npm on my own. |
All my changes are available in my dev branch on: https://github.com/ekacnet/cubism-es/tree/dev. |
The latest version of cubism-es is incompatible with the latest D3 library version realised last September, namely one of the issues is the API change around d3-selection new event manager (
d3.mouse
->d3.pointer
).Is there a plan to upgrade?
If wanted, I can submit a pull request with the changes necessary to both the library and demos.
The text was updated successfully, but these errors were encountered: