Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In PowderCif override the adder #52

Open
sbillinge opened this issue Jun 17, 2021 · 0 comments
Open

In PowderCif override the adder #52

sbillinge opened this issue Jun 17, 2021 · 0 comments

Comments

@sbillinge
Copy link
Collaborator

Right now the loading logic (Checking uints and converting etc.) is done in the constructor, but it would be better to override the adder function and call that from the constructor, which would mean that we could instantiate the object earlier, before we have all the information at hand, and then add it as it becomes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant