Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 release #879

Open
4 of 7 tasks
afk11 opened this issue Apr 26, 2021 · 16 comments
Open
4 of 7 tasks

PHP8 release #879

afk11 opened this issue Apr 26, 2021 · 16 comments

Comments

@afk11
Copy link
Member

afk11 commented Apr 26, 2021

Linking relevant issues and PR's here and any notes

@afk11
Copy link
Member Author

afk11 commented Apr 26, 2021

#876 for phpunit fixup PR

@afk11
Copy link
Member Author

afk11 commented Apr 26, 2021

Merge this #877

@abgit
Copy link

abgit commented Apr 26, 2021

🙏

@satyr-software
Copy link

doesn't murmurhash3 still need ^2.1 for PHP8? ^2.0 still forced PHP ^7 I think.

@abgit
Copy link

abgit commented May 4, 2021

doesn't murmurhash3 still need ^2.1 for PHP8? ^2.0 still forced PHP ^7 I think.

yes. v2.1.0 is the minimum murmurhash3 version for php8 support.

@BafS
Copy link

BafS commented May 31, 2021

^2.0 doesn't force PHP^7, 2.0 does, which is the issue with the current composer file. Would it be possible to update ? It's not a breaking change.

@jorijn
Copy link

jorijn commented Dec 3, 2021

Any update on this? Its been a while :)

@BafS
Copy link

BafS commented Dec 3, 2021

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

@jorijn
Copy link

jorijn commented Dec 3, 2021

@BafS This is awesome! Thanks.

@Aerendir
Copy link

Aerendir commented Jan 5, 2022

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

@BafS
Copy link

BafS commented Jan 5, 2022

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

Here is the commit to make it PHP 8.0 compatible: ProtonMail@b6ec4d2#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

@Aerendir
Copy link

The composer.json doesn't seem to be update to PHP8.0. What am I missing?

Here is the commit to make it PHP 8.0 compatible: ProtonMail@b6ec4d2#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

Thank you!

In the meantime I'm trying to simply skip the checks on the php requirement using

composer install --ignore-platform-req php

But I don't know if all works well now: I'm verifying...

@MatasR
Copy link

MatasR commented Jul 3, 2022

While using ur branch and trying to getHex() from signedTx i get this error (i think its related with PHP8 update):
Fatal error: Uncaught Error: Call to undefined method SplFixedArray::rewind() in C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Mutator\AbstractCollectionMutator.php:43 Stack trace: #0 C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Factory\Signer.php(179): BitWasp\Bitcoin\Transaction\Mutator\AbstractCollectionMutator->rewind() #1 C:\xampp\htdocs\crypto_api\config\Btc.php(47): BitWasp\Bitcoin\Transaction\Factory\Signer->get() #2 C:\xampp\htdocs\crypto_api\api\btc\transfer_from.php(39): Btc->signTransaction(Object(BitWasp\Bitcoin\Transaction\Transaction), Object(BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Key\PrivateKey), '68673') #3 {main} thrown in C:\xampp\htdocs\crypto_api\vendor\protonlabs\bitcoin\src\Transaction\Mutator\AbstractCollectionMutator.php on line 43

@BrianHenryIE
Copy link

This explains it (I haven’t tried to fix it):

SplFixedArray is now IteratorAggregate to support nested loops.

https://markbakeruk.net/2020/11/17/under-the-radar-a-backwards-compatible-break-for-splfixedarray-in-php-8/

@meglio
Copy link

meglio commented Mar 21, 2023

Hey @afk11 have you abandoned it?

@PavelDonskikh
Copy link

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

Yes! it does actually help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants