- All targets must be able to build an IPA. To check this go to Bitrise and select the scheduled build
MATRIX (Beta), adjust your branch name and trigger this build. It will build your the specified target from your branch, run the tests and cuploads an IPA. - The coding guidelines must match.
- Code duplicates are not allowed.
- If you found a typo, copy the sentence, paste it in the Github comment and mark the typo using bold font. This makes it easier for the reviewer to find them if is e.g. a single word. Additionally remember the PR author to enable spell checking in Xcode which helps to avoid typos in PR reviews.
- As a PR creator pleae never close the conversations. This should be done by the one who created the feedback/conversation. It is similar to merging PRs which also has to be decided/done by the reviewer and not the PR creator.
- Try to find the following during review:
- Code that's hard to understand
- Code that's complicated (or not needed)
- Code that's duplicated many times
- Code that depends too much on other code
- Code that can't be replaced easily