Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual QR code cycling #200

Open
ddustin opened this issue Jan 20, 2025 · 1 comment
Open

Manual QR code cycling #200

ddustin opened this issue Jan 20, 2025 · 1 comment

Comments

@ddustin
Copy link

ddustin commented Jan 20, 2025

Issue:

The QR code cycling is entirely broken on my machine, phone, and Jade. None of the devices are able to register any of the other devices QR codes.

Example:

The phone via the Green app, for example, reads a few of the QR codes then fails to read one. Instead of any resuming feature, the phone restarts scanning from the first QR code. This process repeats forever and the series of QR codes is never read.

Desired Behavior:

  • Add the ability to manually click through one QR code at a time. This allows 1) A user to manually decode the QR codes, and, 2) allows for slower QR code scanners to keep up.
  • Make the QR code scanner be able to resume "in-place." This means if a scan fails, it does not start from the beginning but instead waits for the cycle to come back around
This was referenced Jan 20, 2025
@JamieDriver
Copy link
Collaborator

This sounds like an issue on the phone/app side ?

The 'normal' scenario here is the QR 'displayer' encodes a 'message' as N QR codes, which are then displayed in a loop.
The QR 'scanner' usually needs some (any) k of these QRs to reconstitute the original 'message'.

The scanner should just keep scanning until it gets sufficient QR frames. If any QRs are missed or error it should just ignore that and carry on scanning following frames. It should not need to 'discard progress so far and start again'.

Usually the scanner will show some sort of progress bar showing progress to the k unique codes.

All that said - the manual click to proceed to the next frame might work, especially if 'k' is small. But then skipping an individual QR that is, for some reason, problematic to scan should be ok, as you should only need any k-of-N codes - you shouldn't need all N.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants