Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from svg2png #7

Closed
BooDoo opened this issue Sep 6, 2018 · 3 comments
Closed

Migrate away from svg2png #7

BooDoo opened this issue Sep 6, 2018 · 3 comments
Assignees
@BooDoo
Labels
BACKEND BRIDGE for the SEND_STATUS submodule svg2png unexpected behavior from svg2png WIP currently working on this issue

Comments

@BooDoo
Copy link
Owner

BooDoo commented Sep 6, 2018

We rely on svg2png which hasn't been touched for 2 years and relies on PhantomJS.
PhantomJS is being sunset in favor of headless Chrome (via puppeteer).

Should consider alternatives.
@BooDoo BooDoo added BACKEND BRIDGE for the SEND_STATUS submodule labels Sep 6, 2018
@BooDoo BooDoo self-assigned this Sep 6, 2018
@BooDoo
Copy link
Owner Author

BooDoo commented Sep 8, 2018

Planning to try out convert-svg(-to-png) for this purpose in dev/puppeteer branches of Backend and Send_Status.

Probably not needed for now, but may need to consider pooling Chromum sessions at some point if scale expands.

@BooDoo BooDoo added the WIP currently working on this issue label Sep 8, 2018
@BooDoo BooDoo mentioned this issue Sep 8, 2018
Closed
@BooDoo BooDoo added the svg2png unexpected behavior from svg2png label Dec 20, 2022
@BooDoo BooDoo mentioned this issue Dec 20, 2022
Closed
@BooDoo
Copy link
Owner Author

BooDoo commented Dec 23, 2022 •
edited
Loading

In addition to consistency between frontend display and backend results, a number of features are missing from PhantomJS:

SVG use of CSS rotate, opacity, and in-line base64 font loading (but why WOULD you do this one??) and probably a bunch more now 4 years on

@BooDoo BooDoo mentioned this issue Dec 24, 2022
Closed
BooDoo added a commit that referenced this issue Dec 30, 2022
@BooDoo
[BACKEND][BRIDGE] #7 - Migrate away from svg2png
df9b202
@BooDoo
Copy link
Owner Author

BooDoo commented Dec 30, 2022

Closing with df9b202

Doesn't solve our Emoji problems from #18, though.

@BooDoo BooDoo closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BooDoo BooDoo

Labels
BACKEND BRIDGE for the SEND_STATUS submodule svg2png unexpected behavior from svg2png WIP currently working on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BooDoo