Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Swift conflicts with deprecated protocol methods #262

Open
AvdLee opened this issue May 4, 2016 · 1 comment
Open

Swift conflicts with deprecated protocol methods #262

AvdLee opened this issue May 4, 2016 · 1 comment
Labels
bug duplicate swift-specific
Milestone
Swift Rewrite

Comments

@AvdLee
Copy link

AvdLee commented May 4, 2016 •
edited
Loading

screen shot 2016-05-04 at 09 15 32

This result in an annoying error, which can be fixed by implementing the datasource callback as followed:

func lineGraph(graph: BEMSimpleLineGraphView, labelOnXAxisForIndex index: Int) -> String
@Sam-Spencer Sam-Spencer changed the title Result of 'lineGraph(_:labelOnXAxisForIndex:)' has different optionality than required by protocol 'BEMSimpleLineGraphDelegate' Swift conflicts with deprecated protocol methods Jul 2, 2016
@Sam-Spencer
Copy link
Collaborator

It looks like the lineGraph:labelOnXAxisForIndex: was originally implemented on BEMSimpleLineGraphDelegate, but is now implemented on BEMSimpleLineGraphDataSource.

This issue has been reported previously and is fixed on the feature branch in commit 83e8acd. Duplicate of #214.

The feature branch has not yet been merged due to breaking changes that need to be tested and announced. If it's not too difficult for your workflow, I would recommend adopting these changes.

Sam-Spencer pushed a commit that referenced this issue Aug 4, 2017
Add Initial (Partial) Swift Implementation
0a29c20 
Begins to address #105, #214, #262, #275, and #296.
@Sam-Spencer Sam-Spencer added this to the Swift Rewrite milestone May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug duplicate swift-specific
Projects
None yet
Milestone
Swift Rewrite
Development

No branches or pull requests
2 participants
@Sam-Spencer @AvdLee