Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to thread safe version of rust-vst #1

Open
askeksa opened this issue Sep 3, 2018 · 1 comment
Open

Port to thread safe version of rust-vst #1

askeksa opened this issue Sep 3, 2018 · 1 comment

Comments

@askeksa
Copy link

askeksa commented Sep 3, 2018

In https://github.com/askeksa/rust-vst/commits/thread_safe_plugin I have made a proposal for making the rust-vst crate safe.

It could be very interesting to see how this crate could be ported to the new API, in particular in regards to how it could ease some of the parameter communication which is made more complicated by the change.

Pull request is here: RustAudio/vst-rs#65

@Boscop
Copy link
Owner

Boscop commented Nov 20, 2018

Thanks a lot for this!
I'm very busy currently, so I don't have time to do this atm, but I'm also interested in this, to make the thread-safety as ergonomic as possible.

Do you think a branch of easyvst should be based on thread_safe_plugin before that branch is merged into master of the vst crate to inform/refine the design, or is that design already settled?
One of the open questions was which possible multi-threading scenarios can happen in VST hosts, IIRC @wrl said "there are no rules" so we have to ensure that the splitting of the methods (which only allows certain multi-threading scenarios) will work in all popular hosts.
Which hosts have been confirmed to work with the thread_safe_plugin changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants