Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong binsize calculation accumulates offset errors with increasing bin numbers #69

Open
Drmirdeep opened this issue Nov 22, 2019 · 0 comments

Comments

@Drmirdeep
Copy link

There is a crucial bug in the binsize calculation in the bamliquidator.cpp file.
Since the tool needs a gff file as input the length of a region is
"end-start+1" and not "end-start" as in bed format. When demanding 60 bins for a region you get an offset of 60bp for the 60th bin already and thus miss the very end of your region. Further, a regions end position would then be start+binsize-1 if you stick with the gff format. However, I did not check the rest of the code. If it uses half-open intervals start+binsize would be correct of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant