From fa3c42d1d9830a0ff08d8554266f0411e13e3639 Mon Sep 17 00:00:00 2001
From: Ashish Yadav <48384865+criticalAY@users.noreply.github.com>
Date: Wed, 3 Apr 2024 21:28:29 +0530
Subject: [PATCH] fix: unnecessary padding in my_account input layout

---
 AnkiDroid/src/main/res/layout/my_account.xml | 9 ++++-----
 AnkiDroid/src/main/res/values/dimens.xml     | 1 +
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/AnkiDroid/src/main/res/layout/my_account.xml b/AnkiDroid/src/main/res/layout/my_account.xml
index b75e00fdbee1..c433b5ed2928 100644
--- a/AnkiDroid/src/main/res/layout/my_account.xml
+++ b/AnkiDroid/src/main/res/layout/my_account.xml
@@ -31,10 +31,9 @@
                     android:id="@+id/ankidroid_logo"
                     android:layout_width="200dp"
                     app:srcCompat="@drawable/ankidroid_logo"
-                    android:layout_marginBottom="0dp"
+                    android:layout_marginBottom="@dimen/input_layout_padding"
                     android:layout_gravity="center"
-                    android:layout_height="200dp"
-                    />
+                    android:layout_height="200dp" />
 
                 <!--<com.ichi2.ui.FixedTextView-->
                 <!--android:id="@+id/sign_in"-->
@@ -55,7 +54,7 @@
                     android:hint="@string/username"
                     app:endIconMode="clear_text"
                     app:errorEnabled="true"
-                    android:layout_margin="@dimen/content_vertical_padding">
+                    android:layout_marginHorizontal="@dimen/input_layout_padding">
 
                     <com.google.android.material.textfield.TextInputEditText
                         android:id="@+id/username"
@@ -75,7 +74,7 @@
                     android:hint="@string/password"
                     app:endIconMode="password_toggle"
                     app:errorEnabled="true"
-                    android:layout_margin="@dimen/content_vertical_padding">
+                    android:layout_marginHorizontal="@dimen/input_layout_padding">
 
                     <com.ichi2.ui.TextInputEditField
                         android:id="@+id/password"
diff --git a/AnkiDroid/src/main/res/values/dimens.xml b/AnkiDroid/src/main/res/values/dimens.xml
index 0b3819855c10..f2972034785d 100644
--- a/AnkiDroid/src/main/res/values/dimens.xml
+++ b/AnkiDroid/src/main/res/values/dimens.xml
@@ -17,6 +17,7 @@
     <dimen name="dialog_frame_margin">24dp</dimen>
     <dimen name="title_frame_margin_bottom">16dp</dimen>
     <dimen name="content_vertical_padding">8dp</dimen>
+    <dimen name="input_layout_padding">8dp</dimen>
     <dimen name="icon_margin">16dp</dimen>
 
     <!-- Material design typography -->