From 069b8ab18d5a2e4ed2cb51f9cef921b17f782269 Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Thu, 19 Sep 2024 18:12:41 +0530 Subject: [PATCH 1/4] [MM-1108]: Handled the truncation of issue summary while making it a link --- server/issue_parser.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/issue_parser.go b/server/issue_parser.go index 779c8d975..5c6a36627 100644 --- a/server/issue_parser.go +++ b/server/issue_parser.go @@ -21,7 +21,7 @@ func parseJiraLinksToMarkdown(text string) string { } func mdKeySummaryLink(issue *jira.Issue, instance Instance) string { - return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, issue.Fields.Summary, issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) + return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, truncate(issue.Fields.Summary, 80), issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) } func reporterSummary(reporter *jira.User) string { From c7392a4317992a7a983abeb8de89936a37c9ba6d Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Fri, 20 Sep 2024 08:48:22 +0530 Subject: [PATCH 2/4] [MM-1108]: added constant for length --- server/issue_parser.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/issue_parser.go b/server/issue_parser.go index 5c6a36627..09e176be2 100644 --- a/server/issue_parser.go +++ b/server/issue_parser.go @@ -16,12 +16,14 @@ import ( var jiraLinkWithTextRegex = regexp.MustCompile(`\[([^\[]+)\|([^\]]+)\]`) +const issueSummaryMaxLength = 80 + func parseJiraLinksToMarkdown(text string) string { return jiraLinkWithTextRegex.ReplaceAllString(text, "[${1}](${2})") } func mdKeySummaryLink(issue *jira.Issue, instance Instance) string { - return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, truncate(issue.Fields.Summary, 80), issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) + return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, truncate(issue.Fields.Summary, issueSummaryMaxLength), issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) } func reporterSummary(reporter *jira.User) string { From c6d8aafe7f8b9455c6a8450afd918951579d837f Mon Sep 17 00:00:00 2001 From: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com> Date: Mon, 23 Sep 2024 13:27:04 +0530 Subject: [PATCH 3/4] Update server/issue_parser.go Co-authored-by: Raghav Aggarwal --- server/issue_parser.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/issue_parser.go b/server/issue_parser.go index 09e176be2..9d5fec9cc 100644 --- a/server/issue_parser.go +++ b/server/issue_parser.go @@ -16,7 +16,7 @@ import ( var jiraLinkWithTextRegex = regexp.MustCompile(`\[([^\[]+)\|([^\]]+)\]`) -const issueSummaryMaxLength = 80 +const maxIssueSummaryLength = 80 func parseJiraLinksToMarkdown(text string) string { return jiraLinkWithTextRegex.ReplaceAllString(text, "[${1}](${2})") From 59f9c7abb07c9d3309bcb88eddf6c005c87aa84c Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Mon, 23 Sep 2024 13:28:19 +0530 Subject: [PATCH 4/4] [MM-1108]: review fixes --- server/issue_parser.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/issue_parser.go b/server/issue_parser.go index 9d5fec9cc..c09114a2f 100644 --- a/server/issue_parser.go +++ b/server/issue_parser.go @@ -23,7 +23,7 @@ func parseJiraLinksToMarkdown(text string) string { } func mdKeySummaryLink(issue *jira.Issue, instance Instance) string { - return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, truncate(issue.Fields.Summary, issueSummaryMaxLength), issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) + return fmt.Sprintf("[%s: %s (%s)](%s%s)", issue.Key, truncate(issue.Fields.Summary, maxIssueSummaryLength), issue.Fields.Status.Name, instance.GetJiraBaseURL(), "/browse/"+issue.Key) } func reporterSummary(reporter *jira.User) string {