-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browsersync has some vulnerabilities due to localtunnel and axios dependency #2055
Comments
Would it be possible to make |
Note that you mean an optional peer dependency - |
@G-Rath you are right, thanks for the clarification (to be honest I have only read about them and never used them in anger so...)
|
In related news: Somebody has created a PR to patch the Axios package which can be found here: localtunnel/localtunnel#633. I have sort of tried the upgrade and browser-sync doesn't seem to break. The only thing is that this PR hasn't been merged or doesn't seem to have a bump up to new version yet. |
@classicmike I don't think localtunnel is actively being maintained :( |
Hello there.. Browser-sync - package has AXIOS vulnerability; is that addressed in the upcoming release? |
yeah it's time to drop localtunnel, I'll do a 3.0 with it moved |
fixed in #2059 npm i browser-sync@3 :) |
Thankyou - I was about to make my own patched version of localtunnel (just planning on how I'd deploy it to npm) and then use |
Yeah I was considering other ways, but since I assume this has very low usage I'd rather just prune the dep altogether. 👍🏻 |
Thanks @shakyShane for the bump! :) |
For anyone wanting to still use If you want to use it as a direct replacement for "devDependencies" : {
...,
"localtunnel": "https://registry.npmjs.org/@security-patched/localtunnel/-/localtunnel-2.0.2-secpatched.3.tgz",
...,
} |
Issue details
Just ran an
npm audit
and it's listing a couple of vulnerabilities related to Browsersync and its dependencies, namelylocaltunnel
which depends on a version ofaxios
which has apparently got some vulerabilities.Here is the link the the vulnerability report:
Axios Vulnerability Report
Axios had a fix which updated in the last few days.
Normally, this would be a straight forward task by upgrading
localtunnel
, which if it is still actively maintained would've got a version to fix. However it doesn't seem like it's being actively maintained.A few questions:
Thanks.
Please specify which version of Browsersync, node and npm you're running
Affected platforms
Browsersync use-case
If CLI, please paste the entire command below
npm audit or npm audit --fix
The text was updated successfully, but these errors were encountered: