-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build on aarch64_be-unknown-linux-gnu
#174
Comments
This PR was submitted to fix this I think, but did it by just disabling all NEON paths on big endian. Is that the right fix for this? @workingjubilee commented that it should be fixed upstream. And it looks like this PR was just merged upstream to fix the problem. So I guess I'm unclear as to the action item here for memchr. It seems wholly like a problem upstream and not something to be fixed in Can you say more about what specific action you're looking for here? |
I guess the first thing to check here is whether rust-lang/stdarch#1708 is actually in the latest nightly. |
Good point; I tried again here with 2025-02-25, which I assume is more likely to contain rust-lang/stdarch#1708, and the issue still shows up. I know there are ways to check which commits are included in nightly, but I'm not sure what those ways are. Maybe somebody else can chime in. |
I was under the impression that rust-lang/stdarch#1708 ought to fix this, and so I figured that there might be some work memchr might need to do in order to be compatible with that fix. I'm not sure, though - that's just a guess as to the path forward. The proximate issue for us is just being able to compile memchr (and thus compile our CI tests) on aarch64_be; since memchr is just an indirect dependency for us, we don't have any opinions about the best resolution - any resolution that gets memchr compiling is equally good from our perspective. |
All righty. Let's give it a day or two, or until we can confirm that the latest usptream fix doesn't actually help. If so, I can apply the band-aide. |
See this GitHub Actions build failure, which builds memchr 2.7.4 with nightly-2025-02-24 for target
aarch64_be-unknown-linux-gnu
.This may relate to rust-lang/stdarch#1484, which was recently resolved.
Full error output
The text was updated successfully, but these errors were encountered: