Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure AiidaWorkgraph to builder class or inherit from core workflow #82

Open
agoscinski opened this issue Jan 9, 2025 · 0 comments

Comments

@agoscinski
Copy link
Collaborator

It does not really make sense that this is a class as it just converts it to a workgraph. There is no internal state that is abstracted out.

Change to WorkgraphConverter WorkgraphBuilder with a staticmethod to create a workgraph from a core workflow or inherit from the core workflow and just add a to convert the workflow. Will not do this in #45 since rebasing afterwards would be unnecessary work. I think the former is a bit more flexible for the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant