Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate namelist validation inConfigIconTask to dedicated namelist class #84

Open
agoscinski opened this issue Jan 10, 2025 · 1 comment

Comments

@agoscinski
Copy link
Collaborator

Is PR #68 we introduce the field validator for namelist into ConfigIconTask. The reason why we cannot put it in separate class with its own validator but have to iterate here is described here

# validation done here and not in ConfigNamelist so that we can still
# import ConfigIconTaskSpecs in core._tasks.IconTask. Hence the iteration
# over the namelists that could be avoided with a more raw pydantic design

However this might be fixable but it is for the moment too time consuming what the right way is to do as pydantic is complex due to its flexibility.

@leclairm
Copy link
Contributor

Could be solved by a PR addressing #88. Otherwise do it after closing #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants