Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to manga on hosted site. #60

Open
yacob841 opened this issue Feb 28, 2024 · 5 comments
Open

Link to manga on hosted site. #60

yacob841 opened this issue Feb 28, 2024 · 5 comments
Assignees
Labels
api Requires changes to the API enhancement New feature or request frontend

Comments

@yacob841
Copy link

When doing a search it would be nice if when you click on a selection there is a hyperlink to go to the manga on the hosting site. I feel like the value of this will increase once global search is released.

@C9Glax C9Glax added enhancement New feature or request frontend api Requires changes to the API labels Feb 28, 2024
@db-2001 db-2001 self-assigned this Mar 30, 2024
@db-2001
Copy link
Collaborator

db-2001 commented Apr 21, 2024

@C9Glax it doesn't look like the link is currently sent by the API, do you think it'll be possible to make a quick commit to cuttingedge sometime so I can develop the front-end for this feature in the V2 branch?

@C9Glax
Copy link
Owner

C9Glax commented Apr 22, 2024

Currently Manga do not store the URI, and it would be specific to the connector.
So would have to be added, when a Manga is added. Can add for Manga added in the future, but old ones will just have an empty string.

@C9Glax
Copy link
Owner

C9Glax commented Apr 22, 2024

Field websiteUrl is now in the Manga-Object.
C9Glax/tranga@5bdbd9e

@db-2001
Copy link
Collaborator

db-2001 commented Apr 22, 2024

Currently Manga do not store the URI, and it would be specific to the connector. So would have to be added, when a Manga is added. Can add for Manga added in the future, but old ones will just have an empty string.

Couldn't the website url be added in a metadata refresh? I mean tranga has to know the URL in order to check for new chapters, right?

C9Glax added a commit to C9Glax/tranga that referenced this issue Apr 22, 2024
@C9Glax
Copy link
Owner

C9Glax commented Apr 22, 2024

That is something that didn't cross my mind! Just added the two lines that would do that 👍🏼

@db-2001 db-2001 linked a pull request Apr 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Requires changes to the API enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants