Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Split MeshParty into several packages #91

Open
caniko opened this issue Mar 27, 2023 · 5 comments
Open

Request: Split MeshParty into several packages #91

caniko opened this issue Mar 27, 2023 · 5 comments

Comments

@caniko
Copy link

caniko commented Mar 27, 2023

Can we split the skeletonization measures into another package? This package has a lot of bloat around what is otherwise a very useful tool. I am developing meshemy to manipulate meshes in Python, it is still a work in progress, but it provides mesh repair among other functionalities that you provide in MeshParty in addition to the skeletonization.

I will use the source of the skeletonization for now, and hope you split it into something of its own in the future. Thanks.

To be playful with words: A package shouldn't be a party, it should have a well-defined scope.

@ceesem
Copy link
Collaborator

ceesem commented Mar 27, 2023

We’ve been discussing this for a while, and agree in general. The goal of this tool has moved away from neuronal meshes and small mesh cutouts towards morphological analysis of neurons broadly, generally within the CAVE ecosystem. There is some baggage that’s come along in large part due to the evolution of that ecosystem and the standard types of analysis. However, that scope comprises a lot of features that may seem like bloat to you naturally coexist to us.

Is the part of meshparty you’re finding you would like to be it’s own package the graph-based TEASAR implementation? As we think about a major refactor along these lines, I’d be curious what other parts, if any, you found useful for your purposes.

@caniko
Copy link
Author

caniko commented Mar 28, 2023

Thank you for the informal response!

However, that scope comprises a lot of features that may seem like bloat to you naturally coexist to us.

Which I totally understand, I was speaking from my own perspective. I am not interested in the CAVE ecosystem as I find it limiting for the scope of my project, and future ideas.

Is the part of meshparty you’re finding you would like to be it’s own package the graph-based TEASAR implementation?

Yes, along with the add-ons for the modeling of neuron and neurites.

I’d be curious what other parts, if any, you found useful for your purposes.

I did find your animation pipeline intriguing; however, I prefer to explore possibilities through bpy -> Blender. Just the TEASAR implementation.

@fcollman
Copy link
Collaborator

fcollman commented Apr 3, 2023

I started this process! https://github.com/AllenInstitute/PyGraphTEASAR
I have not finished fully testing it on real neurons, but if you wanted to contribute there that would be useful!

@fcollman
Copy link
Collaborator

fcollman commented Apr 3, 2023

This repo has only numpy and scipy as dependancies.

@caniko
Copy link
Author

caniko commented Apr 4, 2023

I started this process! https://github.com/AllenInstitute/PyGraphTEASAR I have not finished fully testing it on real neurons, but if you wanted to contribute there that would be useful!

Thank you! I will check it out some time next week 📅

This repo has only numpy and scipy as dependancies.

Amazing. 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants