Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for methods with underscore names #23

Open
fmcarvalho opened this issue Feb 9, 2017 · 0 comments
Open

Remove support for methods with underscore names #23

fmcarvalho opened this issue Feb 9, 2017 · 0 comments

Comments

@fmcarvalho
Copy link
Contributor

In current API route parameters must be part of both method's name and method's arguments list.

However this incurs on additional issue whenever the user has a mistake and puts a non matching name between arguments and method's name. In this case the connect-controller cannot detect if it is a typo or a deliberate intention of considering that argument as no route parameter, but instead a query-string.

So, to avoid this scenario we should follow the express convention for route paths definition and the user must define the property name as a string, to allow the use of / and : symbols. For simpler cases, without route parameters the user may still use the lower camel name corresponding to the route path.

Finally, remove support for methods defined with underscores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant