Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for exported render function in test-utils #121

Open
andrewebdev opened this issue Sep 24, 2024 · 1 comment
Open

Better naming for exported render function in test-utils #121

andrewebdev opened this issue Sep 24, 2024 · 1 comment

Comments

@andrewebdev
Copy link
Collaborator

In utils/test-utils.tsx, a custom render function is created to wrap the apollo provider. This function is later exported as render. I feel this should rather be something like renderWithAuth. This is because, the basic react testing framework render function is also called render. Having the same name, but with different behaviours, is bound to trip someone up in future.

@jupiter007
Copy link
Collaborator

@andrewebdev sounds good to me. Actually, I can make that change in the branch I'm currently working on, since it's such a small change, it won't add much to the updated pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants