You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In utils/test-utils.tsx, a custom render function is created to wrap the apollo provider. This function is later exported as render. I feel this should rather be something like renderWithAuth. This is because, the basic react testing framework render function is also called render. Having the same name, but with different behaviours, is bound to trip someone up in future.
The text was updated successfully, but these errors were encountered:
@andrewebdev sounds good to me. Actually, I can make that change in the branch I'm currently working on, since it's such a small change, it won't add much to the updated pages.
In
utils/test-utils.tsx
, a custom render function is created to wrap the apollo provider. This function is later exported asrender
. I feel this should rather be something likerenderWithAuth
. This is because, the basic react testing framework render function is also calledrender
. Having the same name, but with different behaviours, is bound to trip someone up in future.The text was updated successfully, but these errors were encountered: