Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Gallery pagination #264

Open
ccheitman opened this issue Apr 26, 2018 · 8 comments
Open

Image Gallery pagination #264

ccheitman opened this issue Apr 26, 2018 · 8 comments

Comments

@ccheitman
Copy link
Contributor

Received an important piece of beta user feedback: We need to have a way for users to page through images instead of having to tack back and forth between an individual image view and the results page.

Also if possible, need a way do a catch-all subject text search.

@ccheitman ccheitman added this to the V1 / Launch milestone Apr 26, 2018
@karindalziel karindalziel modified the milestones: V1 / Launch, V1.5 Apr 26, 2018
@karindalziel
Copy link
Member

@ccheitman I'm going to mark this issue as v1.5, which we'll get to IF there is time at the end. I don't think it's very likely we'll get to it in this version. It's actually a pretty complicated issue, because which picture is "next" depends on the search choices the user made on the previous page, and none of that information is currently being passed though to the individual gallery images.

If you see any other websites that handle this gracefully, please let me know so we can use as an example! How I usually handle this as a user is to use control click to open images in new tabs.

@karindalziel
Copy link
Member

Commenting to note that flickr handles this well. I couldn't find any academic-y sites that did it on a quick glance (except ones that are using javascript to generate the gallery).

@ccheitman
Copy link
Contributor Author

I understand. We did this via Lightbox on the CRA, I believe (@tripodrob ?). But that would be a different technical solution and I agree we don't have time to "change horses midstream." Perhaps it might improve things slightly to open a new window when you click on a thumbnail image? That might make it slightly easier for users to get back to the gallery.

@tripodrob
Copy link
Collaborator

Yeah, we did use a Lightbox variant on CRA.

@jduss4
Copy link
Contributor

jduss4 commented Apr 27, 2018

Opening in a new tab / window is an easy solution for us! We could also do lightbox for a single page of search results without too much difficulty, more likely, although for the sake of making sure we finish everything vital I might put that as a 1.5 solution?

@ccheitman
Copy link
Contributor Author

I'm not sure the new tab/window solution would feel right. Might be frustrating to the user? Lightbox for single page of search results is what we did for the CRA.

@karindalziel
Copy link
Member

I think we can look into that for the future. What I am not sure about re: lightbox is showing all the info alongside the image like we are currently doing. Seems like a lot to fit into an overlay vs a whole other web page. Some testing may be needed.

@karindalziel
Copy link
Member

This is on hold until we can discuss more thoroughly

@karindalziel karindalziel changed the title Image Gallery Image Gallery pagination May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants