Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge missing images on units #373

Open
jduss4 opened this issue May 14, 2018 · 0 comments
Open

Acknowledge missing images on units #373

jduss4 opened this issue May 14, 2018 · 0 comments

Comments

@jduss4
Copy link
Contributor

jduss4 commented May 14, 2018

I was looking into why there was a discrepancy between the unit gallery:

image

and the unit viewer:
image

This is because the unit view is checking for images where file_exists is true, but in the case of poor n/a, it is only associated with images that have no actual file. We should note this when displaying information to the user. Two ideas:

  • either filter by file_exists on gallery description display OR
  • acknowledge the missing images in the unit tab pane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant