Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vignettes for the functions #44

Open
Lextuga007 opened this issue Oct 29, 2021 · 4 comments · Fixed by #45
Open

Vignettes for the functions #44

Lextuga007 opened this issue Oct 29, 2021 · 4 comments · Fixed by #45
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Lextuga007
Copy link
Member

Lextuga007 commented Oct 29, 2021 •
edited
Loading

Recommend set up with the code:

usethis::use_vignette()

Related to issue #11 to update README
@Lextuga007 Lextuga007 added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Oct 29, 2021
@Lextuga007 Lextuga007 linked a pull request Oct 29, 2021 that will close this issue
Vignette for year_date() #45
Merged
@Lextuga007
Copy link
Member Author

@ChrisBeeley what does base_family = "" do? I can't find any information on it from looking at the underlying function theme_bw(), it all just says base_family = "".

nottshcMethods/R/theme.R

Line 17 in a15898d

theme_nottshc <- function(base_size = 12, base_family = "", box = FALSE) {

@ChrisBeeley
Copy link
Member

Do you know, I have no idea. I'm going to ask around

@Lextuga007
Copy link
Member Author

And also update the README.Rmd file (automatically knits to README.md now due to the GitHub Action)

@Lextuga007 Lextuga007 mentioned this issue Mar 3, 2022
Open
@asegun-cod
Copy link

@Lextuga007 Please drop me a slack message on how you think I can help with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vignette for year_date() CDU-data-science-team/nottshcMethods
3 participants
@ChrisBeeley @Lextuga007 @asegun-cod