New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up iterators from disk #356

Closed

1 of 4 tasks

msm-code opened this issue Feb 19, 2023 · 1 comment

Contributor

msm-code commented Feb 19, 2023

Feature Category

Correctness
User Interface / User Experience
Performance
Other (please explain)

Describe the problem

This is just a nitpick (after iterator GC was added to ursadb), but mquery could at least try to avoid leaving too many iterators on disk.

Describe the solution you'd like

Especially "problematic" are:

empty iterators (if query returns 0 files, iterator is still created but never read from so never deleted)
cancelled queries (iterators won't be clened up)

Describe alternatives you've considered

Just do nothing, they will be deleted after 1 day (by default).

msm-cert changed the title ~~Clean up iterators from the disk~~ Clean up iterators from disk

Member

msm-cert commented Sep 16, 2024 •

edited

Loading

Unnecessary after #381 is fixed

msm-cert closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment