Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some naming issues in the data CSV and JSON files. #650

Closed
sei-vsarvepalli opened this issue Nov 13, 2024 · 1 comment
Closed

Some naming issues in the data CSV and JSON files. #650

sei-vsarvepalli opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@sei-vsarvepalli
Copy link
Contributor

Describe the bug
It looks like the CSV files use "Exposure" for "System Exposure (1.0.0)" and "Automatable" for "Virulence (1.0.0)" in the way the JSON decision points are in json/decision_points folder

To Reproduce
I discovered this when trying to automate the CSV files and map them to JSON Decision Points and Decision Point Groups. We should probably rename and label them consistently. there may be other decision points that I have not run through yet.

@sei-vsarvepalli sei-vsarvepalli added the bug Something isn't working label Nov 13, 2024
@ahouseholder ahouseholder self-assigned this Feb 17, 2025
@ahouseholder ahouseholder added the wontfix This will not be worked on label Feb 17, 2025
@ahouseholder
Copy link
Contributor

Those were the names the decision points had at the time they were created. The choice was to either create separate python modules which would then be abandoned since we stopped using those decision points, or to include them in the modules they currently live in. The latter choice allows us to make it obvious that "Exposure" is an earlier version of "System Exposure" and that "Virulence" is an earlier version of "Automatable" even though their names changed.

@ahouseholder ahouseholder closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants