From 439df7472bd70402a2301e949454d110baca7b93 Mon Sep 17 00:00:00 2001 From: Laurent Rineau Date: Thu, 17 Oct 2024 10:33:39 +0200 Subject: [PATCH] leftovers I had not pointed out I have reviewed all modifications. It should be the last batch. --- .../cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake | 2 +- Shape_detection/test/Shape_detection/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake b/Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake index 816ae656fb43..94d2d839375a 100644 --- a/Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake +++ b/Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake @@ -49,7 +49,7 @@ set_property(GLOBAL PROPERTY CGAL_Core_FOUND TRUE) function(CGAL_setup_CGAL_Core_dependencies target) find_package( Boost 1.72 REQUIRED ) - if (!CGAL_DISABLE_GMP AND GMP_FOUND) + if (NOT CGAL_DISABLE_GMP AND GMP_FOUND) use_CGAL_GMP_support(CGAL_Core INTERFACE) endif() target_compile_definitions(${target} INTERFACE CGAL_USE_CORE=1) diff --git a/Shape_detection/test/Shape_detection/CMakeLists.txt b/Shape_detection/test/Shape_detection/CMakeLists.txt index 503af515ccfa..85d23cf07d2b 100644 --- a/Shape_detection/test/Shape_detection/CMakeLists.txt +++ b/Shape_detection/test/Shape_detection/CMakeLists.txt @@ -51,7 +51,7 @@ if(TARGET CGAL::Eigen3_support) set(RANSAC_PROTO_DIR CACHE PATH "") add_executable(test_validity_sampled_data "test_validity_sampled_data.cpp") - target_link_libraries(test_validity_sampled_data CGAL::CGAL CGAL::Data CGAL::Eigen3_support) + target_link_libraries(test_validity_sampled_data PRIVATE CGAL::CGAL CGAL::Data CGAL::Eigen3_support) cgal_add_test(test_validity_sampled_data) else() message(STATUS "NOTICE: Some tests require Eigen 3.1 (or greater), and will not be compiled.")