Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in CGAL 5.6 Mesh_3 with domain derived from Polyhedron_complex_mesh_domain_3 #7681

Closed
sloriot opened this issue Aug 30, 2023 · 2 comments
Assignees
Milestone

Comments

@sloriot
Copy link
Member

sloriot commented Aug 30, 2023

Reverting 39c0a9f
makes it work.

I suspected that the band aid (1f258bc should also be applied to Polyhedron_complex_mesh_domain_3 (as I did not touch init functions in my domain) but it inherits also the functor from Polyhedral_mesh_domain_3.

@sloriot sloriot added Bug Pkg::Mesh_3 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge labels Aug 30, 2023
@sloriot sloriot added this to the 5.6.1 milestone Aug 30, 2023
@sloriot
Copy link
Member Author

sloriot commented Sep 6, 2023

@MaelRL investigated and it turns out that the infinite loop is coming from my custom domain. However, he is not sure if the previous behavior was not done on purpose and there might be other domain defined that could be affected by the behavior change. This needs to be discussed with @lrineau and @janetournois .

@janetournois
Copy link
Member

The remaining questions about initialization have been solved in PR #7552

@lrineau lrineau removed the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants